Repository navigation
Bound chain-transfer retries and validate refund addresses - #388
Merged
Merged
Conversation
added 12 commits
October 2, 2026 15:29
Add a rehearsal of the composed chain settlement path on real SQLite through the real payment handler and the scripted chain: a paid run credited and paid out exactly once with duplicate and mismatching receipts recorded; a lost response resolved by a verified lookup without a second broadcast; the dispatcher stopped after reserving a transfer and before submitting it, resubmitting the stored bytes once with the same digest; stopped after submitting and before recording, resolved after restart with one transfer in total; a failed refund never sent again while an owed one is sent once from its reserved row; the settlement pass delivering a credit once after the inline attempt failed, with duplicate terminal reports ignored; every drill repeated with the database closed and reopened after each step; and disabled mode refusing every chain action, including for leftover chain orders, while TEST flows are unchanged. Each drill asserts the exact rows of the payment tables and the backend call counts. No wallet, network or chain endpoint is involved. GitHub issue #87.
Bring the branch up to date with main after the account recovery change. The schema policy keeps both raised minima: dispatcher 20 from the account recovery migration and executor 7 from the operator disposition migration. Both require the explicit stopped-service database upgrade. GitHub issue #168.
Bring the payout and refund branch at its corrected head under the rehearsal drills, so that they run against the lifecycle as it will merge: the refund outcome returned to callers, bounded reconciliation lookups and the adapter's id validation. GitHub issue #87.
The refund of an unadmitted intent now reports what became of the money besides its error, so the drills read that outcome: nothing transferred when chain payments are disabled, failed after a refund that was not broadcast, and sent once the next refund is confirmed. GitHub issue #87.
Exercise settlement rehearsals alongside the current payment lifecycle, quote pricing, allowances and operator documentation. GitHub issue #87.
Preserve dispatcher schema 23 alongside executor schema 7 and keep the configuration guide aligned with both schema boundaries. GitHub issue #168.
ctfbruce
changed the base branch from
docs/payments-operator-profile
to
fix/retained-work-disposition
October 5, 2026 14:20
ctfbruce
marked this pull request as ready for review
October 5, 2026 14:20
ctfbruce
marked this pull request as draft
October 5, 2026 14:32
Ask operators to verify endpoint and payment kit properties during their deployment rehearsal while retaining the documented recovery limits. GitHub issue #87.
ctfbruce
marked this pull request as ready for review
October 5, 2026 14:47
ctfbruce
marked this pull request as draft
October 5, 2026 14:57
added 3 commits
October 5, 2026 17:19
ctfbruce
marked this pull request as ready for review
October 5, 2026 15:34
ctfbruce
added
the
Ready to merge
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unresolved chain transfer is now resubmitted automatically only during the first hour after reservation. Afterward, reconciliation still checks its digest, preserves the reserved balance and explains when later payouts remain blocked. A retry refused before broadcast no longer treats an earlier uncertain attempt as unpaid.
USDC payment intents reject an invalid refund address before any intent or order is written. Existing orders with an unusable address instead record one failed refund and the amount still owed, without repeated chain calls. TEST behavior is unchanged. No database migration is required.
Validation: SQL binding generation; affected payments, Sui, API and database tests with race detection; vet; dispatcher build. New regressions cover the retry bound, late confirmation, retained balances, invalid-address rejection and legacy owed refunds. Live Sui testnet acceptance is in progress and is not claimed by these fixture checks.
Based on the payment changes in #383; merge after that dependency. Failed refunds continue to require operator handling. The one-hour limit is an application recovery policy, not Sui transaction expiry.
Addresses #385 and #386.