Repository navigation
Update session cookie handling in txadmin client - #40
Merged
Flussen merged 1 commit intoSep 29, 2026
Merged
Conversation
Author
|
I want to get this into the mainline release first, since that's what I'm targeting. though, I don't mind to also port it into develop / 2.0 |
Member
|
LGTM, Please change the target to |
mempler
force-pushed
the
bugfix/robin/rename_txadmin_cookies
branch
from
September 29, 2026 15:20
3792eb1 to
67566ca
Compare
mempler
force-pushed
the
bugfix/robin/rename_txadmin_cookies
branch
from
September 29, 2026 15:23
67566ca to
615e404
Compare
Author
|
@Flussen done |
mempler
force-pushed
the
bugfix/robin/rename_txadmin_cookies
branch
2 times, most recently
from
September 29, 2026 15:30
5c472ce to
c2c3bd2
Compare
mempler
force-pushed
the
bugfix/robin/rename_txadmin_cookies
branch
from
September 29, 2026 15:32
c2c3bd2 to
451baf6
Compare
Author
|
(had to force push a couple of times, github refused me to sign my commits) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
txAdmin 8.1 renamed the session cookie from
tx:<hash>totxa:sess:<hash>. Login still returned HTTP 200, but the dev watcher only kept names starting withtx:, so it reported "no session cookie received from txAdmin" and skipped resource restarts.This accepts both cookie names and still ignores
txa:theme.