Skip to content

fix: Add dotnet10 to supported Lambda runtimes - #393

Open
tippmar-nr wants to merge 1 commit into
newrelic:mainfrom
tippmar-nr:fix/dotnet10-runtime
Open

tippmar-nr wants to merge 1 commit into
newrelic:mainfrom
tippmar-nr:fix/dotnet10-runtime

Conversation

@tippmar-nr

@tippmar-nr tippmar-nr commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Summary

dotnet10 is listed as supported in the README, and the .NET layer is published with dotnet10 as a compatible runtime, but RUNTIME_CONFIG stops at dotnet8. layers install and layers uninstall both reject any runtime not in that dict, so they fail on every .NET 10 function.

 RUNTIME_CONFIG = {
     "dotnet6": {"LambdaExtension": True},
     "dotnet8": {"LambdaExtension": True},
+    "dotnet10": {"LambdaExtension": True},

Evidence

  • Before: on a dotnet10 function, newrelic-lambda layers install stops at layers.py:120 and layers uninstall stops at layers.py:546, both with Unsupported Lambda runtime for '<arn>': dotnet10.
    After: test_add_new_relic_dotnet now covers dotnet6, dotnet8, dotnet10 and sets the CORECLR_* variables for each; test_supports_lambda_extension includes dotnet10. Full suite: 100 passed, black --check clean.

Merge Danger

Door: two-way

Blast Radius: small

Only dotnet10 functions change behavior, from an error to the same install and uninstall paths dotnet8 uses.

🤖 Generated with Claude Code

The README and the .NET layer already list dotnet10, but RUNTIME_CONFIG
stopped at dotnet8, so layers install rejected .NET 10 functions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.58%. Comparing base (0485dd1) to head (4632d8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   70.58%   70.58%           
=======================================
  Files          20       20           
  Lines        1897     1897           
=======================================
  Hits         1339     1339           
  Misses        558      558           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tippmar-nr
tippmar-nr marked this pull request as ready for review November 11, 2026 21:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant