[stable34] fix(k8s): check daemon reachability by deploy id - #1027
Merged
Conversation
Four call sites always ran the Docker ping: ExAppsPageService, Settings\Admin, and the two DaemonConfigController endpoints behind the admin UI's connection checks. On a kubernetes-install daemon that probes a Docker Engine path HaRP does not serve, and it blocks until cURL times out rather than failing fast — so a healthy daemon reads as unreachable, the ExApp deploy button stays disabled and "Check Connection" reports failure. Mirrors the dispatch SetupChecks\DaemonCheck already does.
oleksandr-nc
force-pushed
the
backport/983/stable34
branch
from
September 10, 2026 14:26
9ba162f to
f6db9d9
Compare
oleksandr-nc
marked this pull request as ready for review
September 10, 2026 14:26
oleksandr-nc
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #983
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.