Skip to content

Switch fix-linting to the hardened nf-core/actions reusable workflow - #164

Merged
mashehu merged 1 commit into
devfrom
patch
Oct 7, 2026
Merged

mashehu merged 1 commit into
devfrom
patch

Conversation

@mashehu

@mashehu mashehu commented Oct 7, 2026

Copy link
Copy Markdown
Member

This replaces the old fix-linting workflow (.github/workflows/fix_linting.yml, or .github/workflows/fix-linting.yml in pipelines created before nf-core/tools 3.3.0) with .github/workflows/fix-linting.yml, a short stub that calls the reusable fix-linting workflow from nf-core/actions (nf-core/tools#4485).

The old workflow ran the pull request's own lint hooks in a job that also held the nf-core-bot token. The reusable workflow checks who asked for the fix, runs the pull request's code without any secrets, and pushes the result from a separate job that never runs pull request code.

Commenting @nf-core-bot fix linting on a PR works as before. The next template sync makes the same change on dev.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the Synchronisation documentation.

@mashehu
mashehu merged commit 48858b4 into dev Oct 7, 2026
7 checks passed
@mashehu
mashehu deleted the patch branch October 7, 2026 12:52
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 757c0b4

+| ✅ 265 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   6 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.0.0
  • readme - README did not have a Nextflow minimum version badge.
  • readme - README did not have an nf-core template version badge.
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File does not exist: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-10-07 12:51:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants