Repository navigation
Add contigs input to savana/run + minor version bump - #13108
Merged
Merged
Conversation
erikrikarddaniel
left a comment
Member
There was a problem hiding this comment.
Reviewed with Claude Code.
Thanks, the contigs input itself looks good and matches savana/to. My comments are about the tests:
- The contigs test can't fail. The test genome (
genome.fasta) has onlychr22, and the list given ischr22, so the restriction is a no-op. The nanopore snapshot is unchanged from master, where no list was passed. A test where the list actually excludes something would show the option is honoured. One option: a list naming a contig that has no reads, then check the output is empty. I haven't tried whether SAVANA accepts that. - The default path is no longer tested. Every test now passes a list, so nothing runs without
--contigs(inline suggestion). - The pacbio test now runs the nanopore data and gives an identical snapshot (inline question).
- Minor:
meta.ymlcould say the file has one contig name per line (inline suggestion).
Member
Author
|
The tests have been changed according to the suggestions - empty outputs are asserted for the test where the target contig (chr1) is not in present in the input |
erikrikarddaniel
approved these changes
Oct 9, 2026
erikrikarddaniel
left a comment
Member
There was a problem hiding this comment.
Reviewed with Claude Code.
Thanks, the earlier points are addressed. The chr1 test now shows the contigs list is honoured: I dropped --contigs locally and it fails on variantCount=28. All four tests pass with docker.
Remaining, all minor (inline):
- The chr22 test still has a snapshot identical to "no contig", so it cannot fail on the restriction. I'd drop it.
- In the chr1 test,
assert process.out.findAll { ... }is true for any non-empty map. Snapshotting it pins the version like the other tests. meta.yml: "when empty" reads as an empty file. "when not given" matches what the module handles.
manascripts
force-pushed
the
savana-add-contigs
branch
from
October 12, 2026 13:09
53b1099 to
83434ef
Compare
manascripts
enabled auto-merge
October 12, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
savana/runandsavana/classifymodules to use version1.3.8and adds support for providing an optional contigs list file to restrict analysis to specific contigs. Corresponding tests andmeta.ymlare also updated.PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda