Skip to content

ci: stop the emulated ARM test jobs crashing - #220

Merged
wesnel merged 1 commit into
mainfrom
wgn/ci-arm-emulation
Nov 13, 2026
Merged

wesnel merged 1 commit into
mainfrom
wgn/ci-arm-emulation

Conversation

@wesnel

@wesnel wesnel commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

The aarch64 and armv7 binding tests ran Node under QEMU emulation on x86 runners, and Node crashed there now and then with SIGSEGV, failing a job before any test ran. On #215, "Test bindings on aarch64-unknown-linux-gnu" failed this way, and the same job passed on the same code in another run.

Each job installed QEMU with docker/setup-qemu-action, then ran multiarch/qemu-user-static --reset. That second step replaced the emulators the first had registered with the older image's qemu-*-static builds.

  • aarch64-gnu and aarch64-musl now run on native ubuntu-24.04-arm runners, with no emulation. They also finish in under a minute instead of about four.
  • armv7 has no native runner, so it stays emulated, but without the re-registration. It now uses the emulator setup-qemu-action installs.

Validation

A temporary workflow ran the smoke tests ten times per setup. It's gone from the branch, folded away when the commits are squashed.

Setup aarch64-gnu crashes armv7 crashes
Current, with the re-registration 1 of 10 0 of 10
Without the re-registration 0 of 10 0 of 10
Native ubuntu-24.04-arm 0 of 10 —

The crash was node -e exiting with code 139 under /usr/bin/qemu-aarch64-static, the re-registered emulator. Without the re-registration, the interpreter was /usr/bin/qemu-aarch64 from tonistiigi/binfmt.

Weak spots, assumptions and decisions

  • One crash in ten runs is too little to say how often each setup crashes. What it shows is which emulator was running when Node crashed. The native runners remove emulation either way.
  • aarch64-musl on the native runner wasn't part of the measurement. It uses the same mechanism, and this PR's CI runs it.
  • armv7 is still emulated. A crash there remains possible, just under the maintained emulator.
  • Assumption: ubuntu-24.04-arm runners stay available to this public repository at no cost.
  • Decision: native runners rather than only dropping the re-registration, because that removes emulation for aarch64 completely. Running jest in band was the other alternative. It would hide the crash, not remove it.

Reverting

Two-way door. Only CI configuration changes.

The aarch64 and armv7 binding tests ran Node under QEMU on x86 runners,
and Node crashed there now and then with SIGSEGV, failing a job before
any test ran. Each job installed QEMU with docker/setup-qemu-action and
then re-registered the emulators from multiarch/qemu-user-static, which
replaced them with that image's own qemu-*-static builds. Measured over
ten runs per setup, the one crash came under that image's emulator;
none came with setup-qemu-action's emulator or on a native runner.

Run the two aarch64 jobs on ubuntu-24.04-arm, with no emulation; they
also finish in under a minute instead of about four. armv7 has no native
runner, so it stays emulated, without the re-registration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the ARM smoke-test runner and emulator configuration changes.

No open issues 🎉

What changed in this PR

This PR updates ARM binding smoke-test jobs to avoid the QEMU configuration associated with intermittent Node crashes.

Changes:

  • Move ARM64 GNU and musl tests to native ubuntu-24.04-arm runners, removing QEMU setup and explicit container platform options.
  • Add Node setup before installing dependencies in both ARM64 jobs.
  • Keep ARMv7 emulated, but remove the step that overwrote the emulators installed by setup-qemu-action.
File Description
.github/​workflows/​ci.yml Use native ARM64 runners and simplify ARMv7 emulator setup.

Review effort: Balanced

@kevin-ngrok kevin-ngrok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wesnel
wesnel merged commit e407266 into main Nov 13, 2026
24 checks passed
@wesnel
wesnel deleted the wgn/ci-arm-emulation branch November 13, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants