Skip to content

feat: second-style vector eyelid stress review - #17

Draft
nkcbuilds wants to merge 1 commit into
fix/vector-eyelid-current-reviewfrom
feat/second-style-vector-eye-qa
Draft

nkcbuilds wants to merge 1 commit into
fix/vector-eyelid-current-reviewfrom
feat/second-style-vector-eye-qa

Conversation

@nkcbuilds

Copy link
Copy Markdown
Owner

Purpose

Move beyond one-character tests: exercise the same continuous vector-eye rigging workflow on an independently drawn MIT-licensed chibi and make combined blinking/gaze/head/expression failures visible and reproducible.

Draft stacked PR, base fix/vector-eyelid-current-review (#16). Depends on #16/#15/#14/#13/...; no changes to main.

Code and QA

  • New character qa eye-stress <project-dir> command: for any source/provenance-verified imported Rev2D avatar, render 16 actual 512×640 parameter combinations with eye open/half/closed/wink, gaze ±0.2 in X/Y, head yaw ±8° and pitch ±5°, happy/confused, speaking and multiple simultaneous controls. Strictly require all eight relevant controls and declared numeric ranges; no silent clamping. Produce 4×4 full-frame and enlarged eye contact sheets, numbered original PNGs, JSON with parameter values and model SHA-256. Never change the rig or its approval.
  • Vector-eye review proof advances to version 2: its exact current model SHA-256 now binds four artifacts—neutral blink eye/full sheets, real 36-frame/30fps blink MP4, and the combined expression stress sheet. Version-one/stale/missing/tampered proofs are rejected. character eyes review regenerates all four and keeps the prior approval bit unchanged.
  • Tests for stable 16-case coverage, missing/duplicate/out-of-range controls, v1 proof rejection, stress sheet tampering and existing provenance/approval gates. npm run verify: 236 tests passed across 41 files, TypeScript typecheck/build green.
  • Updated agent skill, CLI help, roadmap, README, vector QA docs and source MIT attribution.

Real second illustration

  • Satoko from rhedak/anime-character-creator, pinned SHA 8a52cd146445b1aee4d890df5e44bcf9102cceef, MIT copyright © 2026 Henrik Hanssen. Completely different flat chibi art from Hana, NOT recolored Hana.
  • Locally resized 800×1000 source to 512×640, imported into a new ignored project, manually placed landmarks using a labelled source-pixel grid, verified the overlay and ran Rev2D validator: 0 warnings. Subsequent PuppetControl build emitted 2 nonblocking body pivot/fade warnings; recorded, not suppressed.
  • Ran character build + character eyes vectorize --experimental: successful fresh four-strip derived eye rig, verified build fingerprints, real 36-frame timed blink; approved:false.
  • Ran the new 16-state stress QA on Satoko and Hana, inspected actual eye sheets. Satoko's vector eyelids visibly improve native raster lash spikes and dark overlap, but near-closed eyes retain a thin green/gray iris trace and simplified lash detail. A legitimate visual quality failure, explicitly documented. Neither rig approved.
  • A separate ignored QA-only copy of Satoko was artificially marked renderable solely to run scene new → scene validate → scene render. Genuine 3-second 90-frame H.264 MP4, 512×640, 30fps, FFprobe acceptance passed; actual 0s/1s/2s frames inspected, consistent source character identity. The source project remains unapproved.

Matched native vs vector eye frames

Satoko native raster eye (top) vs vector eyelids (bottom), six equal controls

Source/copyright notice included; full original art and models remain ignored in .cache/, and only the derived attributed crop is committed.

Limits

This is a second compatible independent character—not proof of production-ready conversion across styles. The closed-eye color trace, limited lash fidelity, face/head seam and full-body motion are unresolved. The stress sheet is a human-review aid and does not automatically detect all defects. QA-only renderer approval must never be treated as user/artist approval.

Please keep this and the entire PR stack draft pending visual design fixes and product acceptance.

@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant