Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Move beyond one-character tests: exercise the same continuous vector-eye rigging workflow on an independently drawn MIT-licensed chibi and make combined blinking/gaze/head/expression failures visible and reproducible.
Draft stacked PR, base
fix/vector-eyelid-current-review(#16). Depends on #16/#15/#14/#13/...; no changes tomain.Code and QA
character qa eye-stress <project-dir>command: for any source/provenance-verified imported Rev2D avatar, render 16 actual 512×640 parameter combinations with eye open/half/closed/wink, gaze ±0.2 in X/Y, head yaw ±8° and pitch ±5°, happy/confused, speaking and multiple simultaneous controls. Strictly require all eight relevant controls and declared numeric ranges; no silent clamping. Produce 4×4 full-frame and enlarged eye contact sheets, numbered original PNGs, JSON with parameter values and model SHA-256. Never change the rig or its approval.character eyes reviewregenerates all four and keeps the prior approval bit unchanged.npm run verify: 236 tests passed across 41 files, TypeScript typecheck/build green.Real second illustration
8a52cd146445b1aee4d890df5e44bcf9102cceef, MIT copyright © 2026 Henrik Hanssen. Completely different flat chibi art from Hana, NOT recolored Hana.character build+character eyes vectorize --experimental: successful fresh four-strip derived eye rig, verified build fingerprints, real 36-frame timed blink; approved:false.scene new→scene validate→scene render. Genuine 3-second 90-frame H.264 MP4, 512×640, 30fps, FFprobe acceptance passed; actual 0s/1s/2s frames inspected, consistent source character identity. The source project remains unapproved.Matched native vs vector eye frames
Source/copyright notice included; full original art and models remain ignored in
.cache/, and only the derived attributed crop is committed.Limits
This is a second compatible independent character—not proof of production-ready conversion across styles. The closed-eye color trace, limited lash fidelity, face/head seam and full-body motion are unresolved. The stress sheet is a human-review aid and does not automatically detect all defects. QA-only renderer approval must never be treated as user/artist approval.
Please keep this and the entire PR stack draft pending visual design fixes and product acceptance.