refactor(nmr): migrate infrastructure to nmr 0.1.0 - #98
Merged
Merged
Conversation
Replace in-house NMR readers and spectral kernels with the pinned library. Retain native datasets, calibration evidence, component semantics, and snapshot v1 across desktop and CLI workflows. Unify import and reset defaults, propagate processing failures, and cover sampling declarations, phase quality, NUS reconstruction, and offline snapshots with regression tests. Remove migration probes and synchronize English and Chinese documentation. Update rustls to 0.23.45 and rustls-webpki to 0.103.15 to resolve RUSTSEC-2026-0285 without adding an advisory exception. Validation: full cargo pr-check passes, including formatting, source sizes, dependency policy, default frontend builds, Clippy, and reference-backend tests (local sccache bypassed due to a cache-service permissions error). Documentation build passed in the prior validation; documentation is unchanged by the dependency fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace PlotX’s in-house NMR readers and spectral processing kernels with the pinned
nmr = 0.1.0library across desktop, CLI, and automation workflows.Validation
cargo pr-check.Limitations
JEOL and Bruker NUS support remains experimental. Repeated sampling coordinates can be imported and persisted but cannot currently be reconstructed. Unsupported acquisition layouts and insufficient calibration produce explicit diagnostics.