Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Install the git-review CLI separately and ensure `git-review` is on `PATH`.
The package does not install the CLI or tuicr.
Remove any manually installed copies of the git-review extension or skill to avoid loading them twice.

The extension source lives in [`pi/extensions/git-review.ts`](pi/extensions/git-review.ts).
The extension source lives in [`pi/extensions/git-review/`](pi/extensions/git-review/), with `index.ts` as its entry point and tests in `tests/`.
It publishes review counts for other extensions and asks the model to use the git-review skill when feedback exists after an agent run.
It defers model notices while a review process holds the shared worktree lock.
Deferred feedback remains eligible for notification after the review ends.
Expand Down
4 changes: 2 additions & 2 deletions mise.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ run = [{ task = "fixers" }, { task = "tests" }, { task = "linters" }]
[tasks.ci-tests]
alias = "test"
description = "Run tests (with the race detector)"
run = ["go test -race -shuffle=on ./...", "node --test pi/extensions/*.test.ts"]
run = ["go test -race -shuffle=on ./...", "node --test pi/extensions/*/tests/*.test.ts"]

[tasks.functional-tests]
description = "Test the compiled CLI and real tuicr through pseudo-terminals"
Expand Down Expand Up @@ -47,7 +47,7 @@ run = [
[tasks.tests]
alias = "test"
description = "Run tests (with the race detector)"
run = ["go test -cover ./...", "node --test pi/extensions/*.test.ts"]
run = ["go test -cover ./...", "node --test pi/extensions/*/tests/*.test.ts"]

#############
# Fix Tasks #
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"description": "Pi integration and agent skill for git-review commit reviews",
"keywords": ["pi-package"],
"pi": {
"extensions": ["./pi/extensions/git-review.ts"],
"extensions": ["./pi/extensions/git-review/index.ts"],
"skills": ["./skills/git-review"],
"prompts": [],
"themes": []
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {
GIT_REVIEW_STATUS_EVENT,
type GitReviewStatus,
type GitReviewStatusRequest,
} from "./git-review/support.ts";
} from "./support.ts";

const GIT_TIMEOUT_MS = 5_000;
const STATUS_TIMEOUT_MS = 15_000;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import assert from "node:assert/strict";
import test from "node:test";
import { parseGitReviewStatus } from "./git-review/support.ts";
import { parseGitReviewStatus } from "../support.ts";

const summary = [
{ state: "needs_review", count: 0 },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { EventEmitter } from "node:events";
import test from "node:test";
import { setImmediate } from "node:timers/promises";
import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
import gitReview from "./git-review.ts";
import { MISE_AFTER_ON_STOP_EVENT, MISE_COORDINATES_EVENT } from "./git-review/support.ts";
import gitReview from "../index.ts";
import { MISE_AFTER_ON_STOP_EVENT, MISE_COORDINATES_EVENT } from "../support.ts";

function harness(mode: ExtensionContext["mode"] = "tui") {
const events = new EventEmitter();
Expand Down
Loading