Repository navigation
Restructure commands and add ability to review files holistically - #20
Merged
Merged
Conversation
Keep formatter corrections separate so later method moves and helper extractions contain no unrelated whitespace or import grouping changes.
Place methods beside their receiver types in the order Constable requires. Keep these moves separate from predicate and complexity repairs.
Name the saved-progress structure so a future recovery-progress check can accept it as an argument. Keep this preparation separate from the later check extraction, as requested in review.
Extract named predicate functions for compound conditions to satisfy Constable.
Store the expected first-stack commit count in each test case so the assertion no longer depends on the test case name.
Extract stack-table rendering into a helper to reduce complexity in `renderResult`.
Extract the existing verbosity assertions into one helper to simplify the status-count integration test.
Extract the existing assertion loop into a helper to reduce complexity in the stack-rewrite integration test.
Git isolation removed `GIT_REVIEW_REAL_TUICR`, so `mise run functional-tests` silently skipped real-tuicr tests even when explicitly enabled. Successful runs therefore gave false confidence without testing real-tuicr. Preserve this opt-in while clearing inherited Git repository settings so explicitly enabled real-tuicr tests execute.
Route live-review checks through status so callers share one command and one versioned JSON response format.
Use `commits` in documentation and result JSON to distinguish stack reviews from upcoming file reviews. Keep `run` as an alias so existing scripts continue to work.
Support reviews of tracked and untracked working-tree files because commit stack reviews cannot cover changes without commits. Distinguish file results from commit results so automation addresses file feedback with new commits rather than fixups. Hold the shared review lock so status checks detect either kind of live review.
Separate interactive prompting from command assembly to prepare for moving command implementations into independent packages.
Move the existing helpers so upcoming command packages can reuse them without importing the code that assembles commands.
Replace the application methods `write` and `writeFiles` with reusable helpers and convert all callers so later command package moves need only relocate code.
Separate the stack-review flags, execution, and interactive prompts from root command assembly so the root only installs the command.
Move command setup, flag values, and execution into the files package so the root command only installs the files command.
Let the status command own its flags and execution separately from the code that assembles the root command.
Give the feedback command ownership of its setup and output so it no longer depends on methods that assemble the root command.
Give approval setup and execution independent ownership with explicit service and output arguments. Remove the unused application verbosity field now that its final caller moved, so this commit stays lint-clean.
Separate the log command's flags and Git invocation from root command assembly. Keep its patch-selection function in the same package to avoid a later lint repair.
Separate command construction from execution so callers can assemble the command tree without running it. Keep `cli.Execute` as the entry point for existing callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.