Repository navigation
Conversation
The icon loader is about to stop using the synthesized Bundle.module accessor, so pull the directory search into a testable helper first. Covers the flat bundle layout shipped in v0.1.1, the structured layout, and the missing-bundle case.
The synthesized Bundle.module accessor traps when it cannot find Timber_Timber.bundle, which crashed the popover on first open in v0.1.1 even though the bundle ships in the release zip. Locate it with the tested TimberModel helper instead and fall back to SF Symbols, so a missing resource degrades instead of trapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.