Repository navigation
Improve mimicry of Cobra completion - #11
Merged
Merged
Conversation
Mimic Cobra by printing the bash script to stdout, but just emit complete -F _git roam since roam wraps git. Reviewed-by: Nathan Nutter <nnutter@duck.com> Reviewed-at: c6168cf67c2720ce643812a0089f13b1a4387f0f
Match Cobra by writing the script to stdout unless --out is given, so users can source or redirect it. Keep the file write with --force when --out is set.
Move the bash command construction out of completionCommand so each shell lives in its own file.
Move the zsh command with its file helpers and embedded script out of completion.go, leaving only the parent command. Reviewed-by: Nathan Nutter <nnutter@duck.com> Reviewed-at: e2d7935505519e1624996ad75be41d577baea07c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.