Repository navigation
Conversation
Automatic hk hook installation will need the same symlink-safe root file check before it inspects `hk.pkl`.
Automatic mise trust and automatic hk hook installation must agree on which repositories are eligible for code-running automation.
Let users enable or disable hk hook installation ahead of worktree creation. Default to disabled because installed hooks can execute repository code.
Run hk install after mise trust when a worktree has a root-level hk.pkl and its GitHub upstream is owned by the user or an organization. Add --mise only when a regular root mise.toml exists so hooks can use mise-managed tools without forcing the option in repositories that do not use mise. Warn and keep the worktree when hk is missing or fails.
The helper only knows the shared `[y/N]` prompt, and automatic hk hook installation tests will use it too.
Automatic mise trust and automatic hk hook installation must present the same account and organization context before asking for consent.
Ask on the first eligible interactive worktree when the setting is undecided, defaulting to No because installed hooks run repository code. Save either answer in a decision marker so an explicit refusal is not mistaken for the disabled default and the prompt does not repeat. Show the GitHub account and organizations covered by the choice, and point to `timber config --auto-hk-install` after refusal.
hk install --mise wraps hooks in mise, so the new worktree must be trusted before hooks are installed. Pin the ordering required by the automatic setup in create.
nnutter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.