feat!: remove deprecated findChilds() alias - #561
Conversation
`findChilds` was renamed to `findChildren` in #363 and has had no internal callers since. It survived only because `src/index.ts` re-exported it via `export * from "./utils"`, which published the name without anyone choosing to. Nothing in `src/` or `test/` referenced it. BREAKING CHANGE: `findChilds()` is removed. Call `findChildren()` instead; the signature and behaviour are identical. Closes #550 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closed in favour of #568 — the same commits, opened from 🤖 Generated with Claude Code |
1 participant
Closes #550
findChildswas renamed tofindChildrenin #363 and has had no internal callers since. It survived only becausesrc/index.tsre-exported it viaexport * from "./utils", which published the name without anyone choosing to. Nothing insrc/ortest/referenced it.Migration
findChilds(node, localName, namespace)→findChildren(node, localName, namespace). Identical signature and behaviour; the alias only ever forwarded. Recorded in the READMEUpgradingsection.On the deprecation warning first
The issue asks whether this needs a runtime warning in a 6.x release before the name disappears — it does.
findChildscarried a bare/** @deprecated */with no replacement named and no runtime signal, so a JavaScript consumer got nothing at all. That half is in #559, which is meant to ship on 6.x beforemasterrolls over to 7.x.Verification
npm run build && npm test && npm run lintclean; 241 passing, unchanged frommaster.🤖 Generated with Claude Code