Skip to content

jenkins: skip SmartOS and AIX for pull request test runs #4458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codebytere wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

jenkins: skip SmartOS and AIX for pull request test runs #4458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions jenkins/scripts/VersionSelectorScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ def noVer = { nodeVersion -> false }
def releaseType = { buildType -> buildType == 'release' }
def testType = { buildType -> buildType == 'test' }
def anyType = { buildType -> true }
// node-test-pull-request passes the pull ref down to every sub-job; daily
// and release jobs pass a branch ref
def isPullRequest = new String(parameters['GIT_REMOTE_REF'] ?: '') ==~ /refs\/pull\/.+/
def prTestType = { buildType -> buildType == 'test' && isPullRequest }

def buildExclusions = [
// Given a machine label, build type (release or !release) and a Node.js
Expand Down Expand Up @@ -66,6 +70,11 @@ def buildExclusions = [
[ /^osx13/, anyType, gte(25) ],
[ /^macos15/, anyType, lt(25) ],

// Not run for pull requests, node-daily-* still covers them
// https://github.com/nodejs/build/issues/4457
[ /^smartos/, prTestType, allVer ],
[ /^aix7/, prTestType, allVer ],

// -------------------------------------------------------
]

Expand Down