Skip to content

Noisy errors hides real errors when testing jest #875

Closed
Closed
Noisy errors hides real errors when testing jest#875

Description

@SimenB
SimenB
opened on Sep 8, 2021
  • Node Version: N/A
  • CitGM Version: N/A
  • Platform: N/A

Ref nodejs/node#40030 (comment), it seems #868 is not enough. @targos could you expand a bit on what's wrong? I would have thought removing the examples would also remove mongo, but apparently not?

Activity

  1. targos commented on Sep 8, 2021

    @targos
    targos
    on Sep 8, 2021
    Member

    Here's an example: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2754/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/jest_v27_1_0/

  2. targos commented on Sep 8, 2021

    @targos
    targos
    on Sep 8, 2021
    Member

    I just realized that there is no citgm release that includes #868 🤦🏻

  3. targos commented on Sep 8, 2021

    @targos
    targos
    on Sep 8, 2021
    Member

    I just published version 8.0.2. This should be fixed.

  4. targos
    closed this as completedon Sep 8, 2021

  5. SimenB commented on Sep 8, 2021

    @SimenB
    SimenB
    on Sep 8, 2021
    MemberAuthor

    Ah, wonderful 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions