Skip to content

lookup: add on-headers - #1099

Open
bjohansebas wants to merge 1 commit into
nodejs:mainfrom
bjohansebas:on-headers
Open

bjohansebas wants to merge 1 commit into
nodejs:mainfrom
bjohansebas:on-headers

Conversation

@bjohansebas

Copy link
Copy Markdown
Member

Unfortunately, this module monkey-patches writeHead. It’s an important module in the Express ecosystem and probably in other key packages that need to use it as a hook for writeHead. Adding it to CITGM wouldn’t be a bad idea while we wait for a solution in Node.js core that would allow us to deprecate this module.

cc: @wesleytodd @UlisesGascon @blakeembrey @ctcpip

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • contribution guidelines followed
    here

Comment thread lib/lookup.json Outdated

@ctcpip ctcpip left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjohansebas

Copy link
Copy Markdown
Member Author

I can't resolve the Prettier warning, it seems to be something outside of this PR.

@bjohansebas
bjohansebas requested a review from ctcpip July 8, 2025 00:10

@UlisesGascon UlisesGascon left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The error in the CI are not related to this change.

I can't resolve the Prettier warning, it seems to be something outside of this PR.

@bjohansebas by running npm run lint:prettier:fix you can see that the changed files are test/reporter/test-reporter-tap.js and test/reporter/test-reporter-junit.js. So we can ignore it 👍

@bjohansebas

Copy link
Copy Markdown
Member Author

cc: @nodejs/citgm

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
@codecov-commenter

codecov-commenter commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (8914dd0) to head (173cd40).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399

Copy link
Copy Markdown
Contributor

Module on-headers fails in Node.js 26.x when manually tested in https://github.com/nodejs/citgm/actions/workflows/test-module.yml

so it does not currently meet the criteria in CONTRIBUTING for submission.

image

cc: @blakeembrey

@MikeMcC399

Copy link
Copy Markdown
Contributor

The issue surfaced by citgm testing against on-headers@1.1.0, released in 2025, and Node.js 26, is resolved in the master branch of on-headers through PR jshttp/on-headers#52 dated May 6, 2026.

I would suggest that on-headers cut a new release to allow citgm to succeed testing with Node.js 26 (and later on Node.js 27 when it is released).

cc: @ctcpip @blakeembrey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants