Repository navigation
lookup: add on-headers - #1099
bjohansebas wants to merge 1 commit into
Conversation
|
I can't resolve the Prettier warning, it seems to be something outside of this PR. |
There was a problem hiding this comment.
LGTM! The error in the CI are not related to this change.
I can't resolve the Prettier warning, it seems to be something outside of this PR.
@bjohansebas by running npm run lint:prettier:fix you can see that the changed files are test/reporter/test-reporter-tap.js and test/reporter/test-reporter-junit.js. So we can ignore it 👍
|
cc: @nodejs/citgm |
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
563a34f to
173cd40
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Module on-headers fails in Node.js 26.x when manually tested in https://github.com/nodejs/citgm/actions/workflows/test-module.yml so it does not currently meet the criteria in CONTRIBUTING for submission.
cc: @blakeembrey |
|
The issue surfaced by citgm testing against on-headers@1.1.0, released in 2025, and Node.js 26, is resolved in the I would suggest that on-headers cut a new release to allow citgm to succeed testing with Node.js 26 (and later on Node.js 27 when it is released). cc: @ctcpip @blakeembrey |

Unfortunately, this module monkey-patches
writeHead. It’s an important module in the Express ecosystem and probably in other key packages that need to use it as a hook forwriteHead. Adding it to CITGM wouldn’t be a bad idea while we wait for a solution in Node.js core that would allow us to deprecate this module.cc: @wesleytodd @UlisesGascon @blakeembrey @ctcpip
Checklist
npm testpasseshere