Skip to content

lookup: skip is-core-module on s390 as node:ffi not supported - #1151

Merged
BethGriggs merged 1 commit into
nodejs:mainfrom
BethGriggs:skip-is-core-module
Oct 1, 2026
Merged

BethGriggs merged 1 commit into
nodejs:mainfrom
BethGriggs:skip-is-core-module

Conversation

@BethGriggs

Copy link
Copy Markdown
Member
Checklist
  • contribution guidelines followed
    here

Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
@BethGriggs BethGriggs changed the title lookup: skip is-core-module on s390 as not supported lookup: skip is-core-module on s390 as ffi not supported Sep 29, 2026
@BethGriggs BethGriggs changed the title lookup: skip is-core-module on s390 as ffi not supported lookup: skip is-core-module on s390 as node:ffi not supported Sep 29, 2026
@codecov-commenter

codecov-commenter commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (4d3d256) to head (563e87c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1151   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BethGriggs
BethGriggs merged commit 8914dd0 into nodejs:main Oct 1, 2026
11 checks passed
@ljharb

ljharb commented Oct 2, 2026

Copy link
Copy Markdown
Member

i'm confused, what's not supported?

@richardlau

Copy link
Copy Markdown
Member

i'm confused, what's not supported?

https://github.com/nodejs/node/blob/4486dce70979133ec1d7a9412807817de9608284/doc/api/ffi.md?plain=1#L38-L43

Which was surprising to those of us on the platform/s390 team as upstream libffi supports Linux on s390x.

@ljharb

ljharb commented Oct 2, 2026

Copy link
Copy Markdown
Member

ok, so the issue is that is-core-module, on s390, expects node:ffi to be available, but it's not?

(what's the issue on windows?)

@MikeMcC399

Copy link
Copy Markdown
Contributor

(what's the issue on windows?)

Question moved to #1163

is-core-module fails on WIndows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants