Skip to content

test: support platform-specific paths - #1092

Merged
ovflowd merged 1 commit into
nodejs:mainfrom
divyanshisingh987456321:agents/run-tests-automation
Sep 7, 2026
Merged

test: support platform-specific paths#1092
ovflowd merged 1 commit into
nodejs:mainfrom
divyanshisingh987456321:agents/run-tests-automation

Conversation

@divyanshisingh987456321

@divyanshisingh987456321 divyanshisingh987456321 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Use environment-aware path handling in Windows-sensitive test assertions while preserving the source behavior.

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

Use environment-aware path handling in Windows-sensitive test assertions while preserving the source behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@divyanshisingh987456321
divyanshisingh987456321 requested a review from a team as a code owner September 7, 2026 06:46
@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Sep 7, 2026 6:49am UTC

Request Review

@divyanshisingh987456321

Copy link
Copy Markdown
Contributor Author

I've updated the PR as discussed. I also noticed that the PR Quality check is currently showing a startup failure because the reusable webpack workflow is not allowed in nodejs/doc-kit. It doesn't appear to be related to the changes in this PR. Please let me know if I need to do anything on my side.

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! Thanks for the contribution 🙇

@ovflowd
ovflowd enabled auto-merge (squash) September 7, 2026 12:27
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.60%. Comparing base (2403f01) to head (808d0d7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files         217      217           
  Lines       20801    20813   +12     
  Branches     1974     1974           
=======================================
+ Hits        18846    18858   +12     
  Misses       1948     1948           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovflowd
ovflowd merged commit e3c6ab8 into nodejs:main Sep 7, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants