Skip to content

lib: support fs_event_wrap in the snapshot and load more modules eagerly - #38737

Closed
joyeecheung wants to merge 3 commits into
nodejs:masterfrom
joyeecheung:eager-load
Closed

joyeecheung wants to merge 3 commits into
nodejs:masterfrom
joyeecheung:eager-load

Conversation

@joyeecheung

@joyeecheung joyeecheung commented May 19, 2021 •

Copy link
Copy Markdown
Member

Now that we support more modules in the snapshot, it's no longer necessary to lazy load them for speeding up startup.

Refs: #35711

So that they are included in the builtin snapshot
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore
@github-actions github-actions Bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels May 19, 2021
@joyeecheung joyeecheung changed the title lib: support fs_event_wrap in the snapshot and eagerly-load more modules lib: support fs_event_wrap in the snapshot and load more modules eagerly May 19, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

joyeecheung added a commit that referenced this pull request May 27, 2021
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request May 27, 2021
So that they are included in the builtin snapshot

PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request May 27, 2021
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore

PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung

Copy link
Copy Markdown
Member Author

Landed in b6471c9...a4ea9fc

danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request May 31, 2021
So that they are included in the builtin snapshot

PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request May 31, 2021
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore

PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request May 31, 2021
@richardlau

Copy link
Copy Markdown
Member

Blocked on #32984.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants