Skip to content

async_hooks: remove legacy AsyncLocalStorage implementation - #63641

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:remove-async-hooks-als
Open

async_hooks: remove legacy AsyncLocalStorage implementation#63641
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:remove-async-hooks-als

Conversation

@mcollina

@mcollina mcollina commented May 29, 2026

Copy link
Copy Markdown
Member

Remove the async_hooks-based AsyncLocalStorage fallback and the --no-async-context-frame flag, making AsyncContextFrame the sole implementation.

@nodejs-github-bot

nodejs-github-bot commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels May 29, 2026
@codecov

codecov Bot commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (a7a9784) to head (280cad9).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63641      +/-   ##
==========================================
- Coverage   92.78%   90.40%   -2.38%     
==========================================
  Files         422      790     +368     
  Lines      192812   275397   +82585     
  Branches    29706    52800   +23094     
==========================================
+ Hits       178900   248982   +70082     
- Misses      13588    16813    +3225     
- Partials      324     9602    +9278
Files with missing lines Coverage Δ
lib/async_hooks.js 100.00% <100.00%> (ø)
lib/internal/async_context_frame.js 100.00% <100.00%> (ø)
lib/internal/async_hooks.js 99.36% <100.00%> (+1.11%) ⬆️
lib/internal/timers.js 100.00% <100.00%> (+2.31%) ⬆️
src/async_context_frame.cc 100.00% <ø> (ø)
src/env-inl.h 94.16% <ø> (ø)
src/env.h 97.40% <ø> (ø)
src/node_options.cc 81.56% <ø> (ø)
src/node_options.h 95.65% <ø> (ø)

... and 493 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added semver-major PRs that contain breaking changes and should be released in the next major version. async_hooks Issues and PRs related to the async hooks subsystem. async_local_storage Issues and PRs related to the AsyncLocalStorage API. labels May 29, 2026
Flarna
Flarna reviewed Jun 2, 2026
View reviewed changes
Comment thread test/parallel/test-stream-finished-async-local-storage.js Outdated
@mcollina
mcollina force-pushed the remove-async-hooks-als branch from 7972ebb to 23b757b Compare August 23, 2026 06:48
@pimterry pimterry mentioned this pull request Aug 25, 2026
Merged
@mcollina
mcollina force-pushed the remove-async-hooks-als branch 2 times, most recently from 777881d to d144ec8 Compare September 19, 2026 07:19
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77668/

@mcollina
async_hooks: remove legacy AsyncLocalStorage implementation
280cad9 
Remove the async_hooks-based AsyncLocalStorage fallback and the
--no-async-context-frame flag, making AsyncContextFrame the sole
implementation.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina force-pushed the remove-async-hooks-als branch from d144ec8 to 280cad9 Compare October 2, 2026 15:56
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78142/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Flarna Flarna Flarna approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. async_local_storage Issues and PRs related to the AsyncLocalStorage API. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mcollina @nodejs-github-bot @jasnell @Flarna @marco-ippolito @addaleax