worker: emit worker exit notifications on BroadcastChannel - #65575
SudhansuBandha wants to merge 5 commits into
Conversation
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65575 +/- ##
==========================================
- Coverage 92.74% 90.40% -2.35%
==========================================
Files 422 791 +369
Lines 193170 276057 +82887
Branches 29783 52983 +23200
==========================================
+ Hits 179160 249575 +70415
- Misses 13682 16902 +3220
- Partials 328 9580 +9252
π New features to boost your workflow:
|
4dd297f to
d8a79bf
Compare
f23efdb to
b1c9fb9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
b1c9fb9 to
f3007df
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
@MikeMcC399 I have not received any failure on my Windows machine because of my changes in PR. Can you provide me a suitable approach where I can recreate the CI failure on Windows machine. Will WSL/MSYS2 help in this regards? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Thank you @MikeMcC399 for your help. I believe I have missed a failing test in my changes which I am currently looking at it. Hopefully CI issues will get resolved after this. |
c1b0497 to
ccc39ae
Compare
|
@MikeMcC399 I have fixed the failing test but still the CI issue is not getting resolved. If it is possible, can you or anyone else debug these failing CI issues against the test suite on Linux/MacOs. I am not able to reproduce on Windows and due to limited hardware resources it is difficult for me to have a dual setup of Windows and Linux on my machine |
|
I'm sorry, I won't be able to help you further with the test problems. |
Expose worker termination notifications through BroadcastChannel so consumers can observe when a worker exits andinspect its thread ID and exit code. Fixes: nodejs#59053 Signed-off-by: SudhansuBandha <bandhasudhansu@gmail.com>
83e569e to
c0f9084
Compare
|
@MikeMcC399 CI looks to be good for now. Hope that we can take this further!!!π |
Perhaps @addaleax will be able to review again now that your tests are succeeding? |
Expose worker termination notifications through BroadcastChannel so consumers can observe when a worker exits and inspect its thread ID and exit code.
Fixes: #59053