http: drain server request before destroying - #65674
Open
dayun6530 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Dayun <dlekdbs6530@gmail.com>
Collaborator
|
Review requested:
|
dayun6530
marked this pull request as ready for review
August 31, 2026 01:04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65674 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.01%
==========================================
Files 754 754
Lines 255747 255748 +1
Branches 48318 48327 +9
==========================================
- Hits 230327 230309 -18
+ Misses 16550 16546 -4
- Partials 8870 8893 +23
🚀 New features to boost your workflow:
|
ronag
requested changes
Aug 31, 2026
ronag
left a comment
Member
There was a problem hiding this comment.
Something more fundamental is wrong here. The socket should not be re-used if destroyed without being fully consumed and anything else in the pipeline queue should also be cancelled.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #49429
When a server
IncomingMessageis consumed using an async iterator anditeration terminates before the request body is fully consumed, the
IncomingMessageis destroyed while the underlying keep-alive socketremains open.
Pending request body data can then be pushed to the destroyed stream.
push()returnsfalse, causing the HTTP parser to pause the socket.A subsequent request that reuses the same keep-alive socket can then stall.
This change dumps the remaining server request body before detaching and
destroying the
IncomingMessage.A regression test verifies that a subsequent request can reuse the same
keep-alive socket without timing out.
Tests:
python3 tools/test.py --mode=release parallel/test-http-server-for-await-keepalivepython3 tools/test.py --mode=release parallel/test-http-client-abort-keep-alive-destroy-res parallel/test-http-agent-keepalivepython3 tools/test.py --mode=release parallel/test-stream-readable-async-iterators parallel/test-stream-pipeline-async-iteratormake lint-js