Skip to content

test: wait for ZIP source streams to close - #66429

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:test-zlib-zip-cleanup
Open

test: wait for ZIP source streams to close#66429
panva wants to merge 1 commit into
nodejs:mainfrom
panva:test-zlib-zip-cleanup

Conversation

@panva

@panva panva commented Oct 1, 2026

Copy link
Copy Markdown
Member

A destroyed read stream can still have a pending open or close. Wait for closure before removing the temporary files, so cleanup cannot race a pending open and cause ENOENT in test-zlib-zip-files.

https://ci.nodejs.org/job/node-test-commit-aix/65820/nodes=aix73-power9/testReport/junit/(root)/parallel/test_zlib_zip_files/

@panva
test: wait for ZIP source streams to close
440da08 
A destroyed read stream can still have a pending open or close. Wait for
closure before removing the temporary files, so cleanup cannot race a
pending open and cause ENOENT in test-zlib-zip-files.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
@panva panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Oct 1, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 1, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78118/

mcollina
mcollina approved these changes Oct 1, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (cede7e6) to head (440da08).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #66429      +/-   ##
==========================================
- Coverage   90.39%   90.38%   -0.01%     
==========================================
  Files         792      792              
  Lines      275697   275697              
  Branches    52868    52860       -8     
==========================================
- Hits       249208   249185      -23     
- Misses      16892    16898       +6     
- Partials     9597     9614      +17

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78121/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panva @nodejs-github-bot @mcollina