test: treat tests without a callback as todo - #66435
AyushShende2679 wants to merge 1 commit into
Conversation
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
|
The correct submodule is I think I agree with this idea (I haven't looked at the implementation yet). |
This comment was marked as resolved.
This comment was marked as resolved.
|
This PR is failing almost all tests. See the comments in the tests for more detail. See also Pull requests > Step 6: Test with further details in the linked document section BUILDING > Running tests.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66435 +/- ##
==========================================
- Coverage 90.39% 90.36% -0.03%
==========================================
Files 792 792
Lines 275697 275733 +36
Branches 52868 52861 -7
==========================================
- Hits 249208 249166 -42
- Misses 16892 16952 +60
- Partials 9597 9615 +18
🚀 New features to boost your workflow:
|
Signed-off-by: AyushShende2679 <ayushshende2679@gmail.com>
1fa4305 to
314cf63
Compare
Summary
Tests created without a callback are currently reported as passing tests.
For example: