Skip to content

test: treat tests without a callback as todo - #66435

Open
AyushShende2679 wants to merge 1 commit into
nodejs:mainfrom
AyushShende2679:fix/test-runner-empty-test
Open

AyushShende2679 wants to merge 1 commit into
nodejs:mainfrom
AyushShende2679:fix/test-runner-empty-test

Conversation

@AyushShende2679

Copy link
Copy Markdown

Summary

Tests created without a callback are currently reported as passing tests.

For example:

test('test with no callback');

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@JakobJingleheimer

Copy link
Copy Markdown
Member

The correct submodule is test_runner (confusing, I know).

I think I agree with this idea (I haven't looked at the implementation yet).

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399

MikeMcC399 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

This PR is failing almost all tests. See the comments in the tests for more detail.

See also Pull requests > Step 6: Test with further details in the linked document section BUILDING > Running tests.

To run the linter, use make lint / vcbuild lint. It will lint JavaScript, C++, and Markdown files.

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.36%. Comparing base (cede7e6) to head (314cf63).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/test.js 93.10% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66435      +/-   ##
==========================================
- Coverage   90.39%   90.36%   -0.03%     
==========================================
  Files         792      792              
  Lines      275697   275733      +36     
  Branches    52868    52861       -7     
==========================================
- Hits       249208   249166      -42     
- Misses      16892    16952      +60     
- Partials     9597     9615      +18     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.52% <93.10%> (-1.43%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: AyushShende2679 <ayushshende2679@gmail.com>
@AyushShende2679
AyushShende2679 force-pushed the fix/test-runner-empty-test branch from 1fa4305 to 314cf63 Compare October 1, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants