Skip to content

process: mark process.finalization as release candidate #66436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollina wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −7
Open

process: mark process.finalization as release candidate #66436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions doc/api/process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2062,9 +2062,13 @@ Since it's not possible to build Node.js without libuv, this value is always `tr

<!-- YAML
added: v22.5.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/66436
description: Marked as release candidate.
-->

> Stability: 1.1 - Active Development
> Stability: 1.2 - Release candidate

* `ref` {Object | Function} The reference to the resource that is being tracked.
* `callback` {Function} The callback function to be called when the resource
Expand Down Expand Up @@ -2171,9 +2175,13 @@ as it is not guaranteed that the callback will be called under all circumstances

<!-- YAML
added: v22.5.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/66436
description: Marked as release candidate.
-->

> Stability: 1.1 - Active Development
> Stability: 1.2 - Release candidate

* `ref` {Object | Function} The reference
to the resource that is being tracked.
Expand All @@ -2192,9 +2200,13 @@ this means that there is a possibility that the callback will not be called unde

<!-- YAML
added: v22.5.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/66436
description: Marked as release candidate.
-->

> Stability: 1.1 - Active Development
> Stability: 1.2 - Release candidate

* `ref` {Object | Function} The reference
to the resource that was registered previously.
Expand Down
4 changes: 0 additions & 4 deletions lib/internal/process/finalization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ const {
SafeWeakRef,
} = primordials;
const { validateObject, kValidateObjectAllowFunction } = require('internal/validators');
const { emitExperimentalWarning } = require('internal/util');

function createFinalization() {
/**
Expand Down Expand Up @@ -97,7 +96,6 @@ function createFinalization() {
* @param {Function} fn
*/
function register(obj, fn) {
emitExperimentalWarning('process.finalization.register');
validateObject(obj, 'obj', kValidateObjectAllowFunction);

_register('exit', obj, fn);
Expand All @@ -110,7 +108,6 @@ function createFinalization() {
* @param {Function} fn
*/
function registerBeforeExit(obj, fn) {
emitExperimentalWarning('process.finalization.registerBeforeExit');
validateObject(obj, 'obj', kValidateObjectAllowFunction);

_register('beforeExit', obj, fn);
Expand All @@ -121,7 +118,6 @@ function createFinalization() {
* @param {object} obj
*/
function unregister(obj) {
emitExperimentalWarning('process.finalization.unregister');
if (!registry) {
return;
}
Expand Down
Loading