test: do not hardcode V8 serialization header - #66442
Open
joyeecheung wants to merge 1 commit into
Open
joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
joyeecheung
added
the
fast-track
Contributor
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
joyeecheung
force-pushed
the
fix-header
branch
from
October 1, 2026 18:27
9c2b997 to
b905969
Compare
The header changes when V8 is updated. Do not hardcode it to avoid breaking V8 updates. The update should only surface in test/parallel/test-v8-serdes.js Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
force-pushed
the
fix-header
branch
from
October 1, 2026 18:32
b905969 to
0aa1c1b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66442 +/- ##
==========================================
- Coverage 90.39% 90.37% -0.02%
==========================================
Files 792 792
Lines 275723 275723
Branches 52867 52859 -8
==========================================
- Hits 249237 249183 -54
- Misses 16894 16956 +62
+ Partials 9592 9584 -8 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header changes when V8 is updated. Do not hardcode it to avoid breaking V8 updates. The update should only surface in test/parallel/test-v8-serdes.js.
Refs: #65161