Conversation
- Compile gen/icudt*.c instead of .S. - Check required environment variables and configure.py args are set. - Remove no-longer needed variables. Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
- Don't use icu data file on z/OS; use libnode's bundled ICU data. - Include required defines, cflags, ldflags, and remove unsupported ones, following switch to clang compiler. - Remove _ALL_SOURCE, as _POSIX_C_SOURCE and _POSIX_SOURCE already enable all required library functions (in deps/uv/CMakeLists.txt, only _OPEN_SYS is required to enable setgroups (in grp.h) instead of _ALL_SOURCE); also remove dup _OPEN_SYS_SOCK_IPV6. - Add -D_EXT to defines (for setenv, and vsam.js' `__KEY_*` macros). - Add _POSIX_C_SOURCE=200809L to enable at least `utimensat`. - Add clang option -mzos-target=zosv2r5 also to ldflags, otherwise the default LE dataset is used that may not be for the current target. - Add -m64 to ldflags, otherwise ld passes `AMODE=31,LIST,..` to the binder, causing unresolved symbols if the non-64 suffixed version of the compiler was used (e.g. ibm-clang instead of ibm-clang64). - Add zoslib/include-wrappers/c++ in include_dirs for custom aligned new and delete operators. Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Contributor
Author
|
For the lint error stating to use dict.get() instead, please note that in this case we want configure.py to terminate if the environment variable isn't set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see each commit's message for description. All changes here affect z/OS only.