Conversation
leah-1ee
marked this pull request as ready for review
October 2, 2026 15:47
nodejs-github-bot
added
the
typings
Reuse HandleWrap across derived internal binding types. Assisted-by: Codex Signed-off-by: leah-1ee <selee3196@gmail.com>
leah-1ee
force-pushed
the
typings/handlewrap-derived-types
branch
from
October 2, 2026 15:52
5a05052 to
035f30f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #66150.
Apply the shared
HandleWrapinterface toFSEvent,Process,StatWatcher, andELDHistogram, reflecting their native inheritanceand JavaScript prototype chains.
This removes duplicate declarations and exposes inherited methods
already available at runtime. It also allows the existing optional
callback for
StatWatcher.close(). Runtime behavior is unchanged.Assisted-by: Codex