build: fix vcbuild format-md install and exit - #66475
Open
vedchaudhari wants to merge 1 commit into
Open
vedchaudhari wants to merge 1 commit into
vedchaudhari wants to merge 1 commit into
Conversation
Install the Markdown linter before formatting and exit afterwards. Assisted-by: Claude Code Signed-off-by: vedchaudhari <vedc2853@gmail.com>
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
lpinca
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
vcbuild format-md, the shortcut that skips building wentstraight to
format-mdand skippedlint-md-build. This meant theMarkdown dependencies were not installed on a fresh clone, causing
the command to print the source tarball message without formatting
anything.
Also,
format-mddid not exit after formatting, so execution fellthrough to
no-lintand printed the same misleading message.Make the
format-mdshortcut go throughlint-md-buildfirst andexit after formatting.
I ran
vcbuild format-mdafter deletingtools\lint-md\node_modulesto verify the Markdown dependencies are installed and formatting works on a fresh checkout. It completed without the source tarball message and exited with code 0. I ranvcbuild format-mdagain with the dependencies already installed, and also checked thatvcbuild lint-mdandvcbuild lintstill work. No files underdoc\were changed. There are no automated tests forvcbuild.bat, so I tested the fix manually.Refs: #66467
Assisted-by: claude:opus-5.5