Skip to content

build: fix vcbuild format-md install and exit - #66475

Open
vedchaudhari wants to merge 1 commit into
nodejs:mainfrom
vedchaudhari:fix-vcbuild-format-md
Open

vedchaudhari wants to merge 1 commit into
nodejs:mainfrom
vedchaudhari:fix-vcbuild-format-md

Conversation

@vedchaudhari

Copy link
Copy Markdown

With vcbuild format-md, the shortcut that skips building went
straight to format-md and skipped lint-md-build. This meant the
Markdown dependencies were not installed on a fresh clone, causing
the command to print the source tarball message without formatting
anything.

Also, format-md did not exit after formatting, so execution fell
through to no-lint and printed the same misleading message.

Make the format-md shortcut go through lint-md-build first and
exit after formatting.

I ran vcbuild format-md after deleting tools\lint-md\node_modules to verify the Markdown dependencies are installed and formatting works on a fresh checkout. It completed without the source tarball message and exited with code 0. I ran vcbuild format-md again with the dependencies already installed, and also checked that vcbuild lint-md and vcbuild lint still work. No files under doc\ were changed. There are no automated tests for vcbuild.bat, so I tested the fix manually.

Refs: #66467

Assisted-by: claude:opus-5.5

Install the Markdown linter before formatting and exit afterwards.

Assisted-by: Claude Code
Signed-off-by: vedchaudhari <vedc2853@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants