doc: document linux-x64-musl build toolchain - #66523
Open
theSnackOverflow wants to merge 1 commit into
Open
theSnackOverflow wants to merge 1 commit into
theSnackOverflow wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
This comment was marked as resolved.
This comment was marked as resolved.
theSnackOverflow
force-pushed
the
doc-66506-musl-toolchain
branch
from
October 5, 2026 07:00
4e16d56 to
fa60260
Compare
Contributor
Author
|
@MikeMcC399 I forgot to translate the PR description and commit message into English. Thanks for pointing this out! Both are now updated. |
Contributor
|
Please be careful when you are using AI and note the AI use policy and guidelines. You should not be posting any unreviewed content or allowing AI to automatically post without supervision. Thank you for making the correction! |
richardlau
approved these changes
Oct 5, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Add the build platform and compiler for official musl binaries. Signed-off-by: Ji Hoon Kang <ivory.ma9ic@gmail.com> Assisted-by: Codex
theSnackOverflow
force-pushed
the
doc-66506-musl-toolchain
branch
from
October 5, 2026 15:46
fa60260 to
a798dcc
Compare
lpinca
approved these changes
Oct 5, 2026
jasnell
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The platform and toolchain table in
BUILDING.mdis missing the build environment for the officiallinux-x64-muslbinaries.nodejs/build#4414, which added the release machine, specifies an Alpine 3.23 container. The Dockerfile installs
clang21, and the compiler selection script selects Clang for Alpine builds of Node.js 25 and later.Add
Alpine 3.23 with Clang 21to the table based on these build settings. This is a one-row documentation change with no effect on runtime behavior or minimum supported platform versions.Validation:
node tools/lint-md/lint-md.mjs BUILDING.mdgit diff --checkFixes: #66506
Assisted-by: Codex