tools: copy hdr_histogram_internal.h in update-histogram.sh - #66528
Open
fcostaoliveira wants to merge 1 commit into
Open
fcostaoliveira wants to merge 1 commit into
fcostaoliveira wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
HdrHistogram_c 0.12.0 added a private header, src/hdr_histogram_internal.h, which src/hdr_tests.h now includes. update-histogram.sh copies a fixed list of files, so the automated update to 0.12.0 would leave deps/histogram without it and fail to compile. Add the header to the list. Signed-off-by: fcostaoliveira <filipe@redis.com>
fcostaoliveira
force-pushed
the
tools-histogram-updater-header
branch
from
October 5, 2026 10:02
981399c to
532f6c7
Compare
richardlau
approved these changes
Oct 5, 2026
aduh95
approved these changes
Oct 5, 2026
jasnell
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/dep_updaters/update-histogram.shcopies a fixed list of files from the HdrHistogram_c release intodeps/histogram.HdrHistogram_c 0.12.0 (released 2026-10-02, https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.12.0) made
src/hdr_tests.hinclude a new private header,src/hdr_histogram_internal.h, and that header is not on the list.As a result the automated update, #66494, fails to build in CI:
This adds the header to the
cpline. Nothing else changes:histogram.gyp,BUILD.gnandunofficial.gnilist onlysrc/hdr_histogram.cand the public header, and the other files 0.12.0 needs (hdr_atomic.h,hdr_malloc.h,hdr_tests.h) are already copied.The 0.12.0 update itself is not part of this PR; it is #66494, which still needs the header file added (see my comment there).
How I checked it:
#includes ofsrc/hdr_histogram.cat the0.12.0tag, transitively: it needshdr_histogram.h,hdr_atomic.h,hdr_tests.h,hdr_histogram_internal.hand itself. Before this change onlyhdr_histogram_internal.his missing from the copy list.tools/dep_updaters/update-histogram.shin a checkout of main (c56cb094), which fetched 0.12.0:deps/histogram/src/hdr_histogram_internal.happears as a new file with this change. Syntax-checked withcc -fsyntax-only -Ideps/histogram/src -Ideps/histogram/include deps/histogram/src/hdr_histogram.c, which succeeds. I did not run a full Node build. I then discarded the update, so this PR contains only the one-line script change.AI use disclosure: I used an AI coding assistant (Claude Code) to analyse the updater script against the 0.12.0 tag and to draft this one-line patch and this description. I reviewed the change and the include analysis myself and I will answer review comments myself. I am a maintainer of HdrHistogram_c.