Skip to content

permission: keep explicit fs grants when dropping a covering directory - #66556

Open
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:keep-explicit-fs-grants-when-dropping-a-covering-d
Open

permission: keep explicit fs grants when dropping a covering directory#66556
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:keep-explicit-fs-grants-when-dropping-a-covering-d

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 6, 2026

Copy link
Copy Markdown
Member

permission: keep explicit fs grants when dropping a covering directory

@RafaelGSS
permission: keep explicit fs grants when dropping a covering directory
2fdbe15 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. labels Oct 6, 2026
@RafaelGSS
permission: fix clang-format in GrantAccess
d830a67 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@codecov

codecov Bot commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.41%. Comparing base (fcfb7ec) to head (d830a67).
⚠️ Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
src/permission/fs_permission.cc 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #66556   +/-   ##
=======================================
  Coverage   90.40%   90.41%           
=======================================
  Files         791      791           
  Lines      276226   276234    +8     
  Branches    53045    53046    +1     
=======================================
+ Hits       249732   249755   +23     
+ Misses      16899    16890    -9     
+ Partials     9595     9589    -6
Files with missing lines Coverage Δ
src/permission/fs_permission.cc 76.66% <93.75%> (+7.35%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS

RafaelGSS commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

ping @marco-ippolito @UlisesGascon

@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 8, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78258/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RafaelGSS @nodejs-github-bot @UlisesGascon