Repository navigation
Conversation
Copy validated header names directly into the shallow result instead of using ObjectAssign on the internal null-prototype map. Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66592 +/- ##
==========================================
+ Coverage 90.44% 90.45% +0.01%
==========================================
Files 791 791
Lines 276486 276568 +82
Branches 53092 53117 +25
==========================================
+ Hits 250060 250169 +109
+ Misses 16846 16802 -44
- Partials 9580 9597 +17
🚀 New features to boost your workflow:
|
pimterry
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
gurgunday
approved these changes
Oct 9, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
resume-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
ObjectAssigninHttp2ServerResponse.getHeaders()with an explicitkey-copy loop, preserving the null-prototype shallow copy. Add a benchmark
and compatibility coverage.
On Apple M2 / macOS, compared against
4fa5145:
30 samples per binary and configuration, with 1,000,000 calls per sample.
These results measure
getHeaders()throughput, not HTTP request throughput.