Repository navigation
Conversation
This is not impactful in any way - it's a fixed leak of the openssl record compression descriptors, about 24 bytes leaked total, once per process. Not meaningful. It is annoying if you want to run with ASAN & leak detection though, since it's an unambiguous leak we trigger every time crypto is used. Signed-off-by: Tim Perry <pimterry@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66600 +/- ##
==========================================
- Coverage 90.44% 90.44% -0.01%
==========================================
Files 791 791
Lines 276562 276565 +3
Branches 53126 53117 -9
==========================================
+ Hits 250130 250131 +1
+ Misses 16846 16842 -4
- Partials 9586 9592 +6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not impactful for normal users at all - it's a fixed leak of the openssl record compression descriptors, about 24 bytes leaked total, once per process.
It is very annoying though if you want to run with ASAN & leak detection to check for other issues. It's an unambiguous memory leak we hit effectively every run where crypto is used.
The change here ensures we individually free the descriptors, in addition to emptying the stack that references them. There's an existing test that confirms this doesn't accidentally re-enable record compression somehow.