Repository navigation
fix(http1): accept unsolicited 100 responses - #5918
Open
GiHoon1123 wants to merge 1 commit into
Open
GiHoon1123 wants to merge 1 commit into
GiHoon1123 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5918 +/- ##
=======================================
Coverage 91.53% 91.54%
=======================================
Files 113 113
Lines 43597 43592 -5
=======================================
- Hits 39908 39905 -3
+ Misses 3689 3687 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GiHoon1123
force-pushed
the
fix-http1-ignore-unsolicited-100
branch
from
October 9, 2026 12:52
25c156b to
8987ebb
Compare
Contributor
Author
|
Thanks for testing those cases. I rebased on the current main after #5961, and the new CI run passed, including the Node 22 job that failed before. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5899
An unsolicited HTTP/1.1 100 Continue response should not terminate the connection. The client can ignore the interim response and continue parsing the final response.
The HTTP/1 parser was treating every 100 response as a bad response and destroying the socket. This change removes that special-case failure and keeps the existing informational-response handling.
The regression test covers:
Tests: