fix: report signature checks skipped without registry keys - #10048
Open
greenlincoln05 wants to merge 2 commits into
Open
greenlincoln05 wants to merge 2 commits into
greenlincoln05 wants to merge 2 commits into
Conversation
greenlincoln05
marked this pull request as ready for review
September 27, 2026 23:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm audit signaturescan exit successfully after checking packages from registries with signing keys while silently omitting packages from registries without keys. In a mixed tree, it now reports the skipped count by registry host in the text summary and askippedarray with--json. The existing exit status and the error when no packages can be audited stay the same.The reported registry origin omits URL paths and credentials. The key-fallback warning uses the same safe origin, so a registry URL containing a credential in its path is not echoed into audit output or logs.
Fixes #10018
Validation:
test/lib/commands/audit.jssuite passed, including the credential-bearing registry regression (using a test-only compatibility preload for this host's cached dependency tree).git diff --checkpassed.