Repository navigation
fix: reject numeric segments after x-ranges in tilde and caret ranges - #931
Open
Enesuygurs wants to merge 1 commit into
Open
Enesuygurs wants to merge 1 commit into
Enesuygurs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e583226 made x-ranges with a number after a wildcard invalid, so
1.x.5,x.1andx.1.2now throw. That check only runs inreplaceXRange. The same input behind~or^is still accepted, and the trailing numbers are silently dropped:^x.1.2turning into*is the worst case: a mistyped range validates and matches every version.This PR calls the existing
invalidXRangeOrder()check fromreplaceTildeandreplaceCaretas well, so these ranges are rejected the same way the bare x-range is. In loose mode the invalid token is dropped, which matches the existing1.x.5 || 2.xloose fixture.Tests: I added rows to
test/fixtures/range-parse.jsfor~1.x.5,~>1.*.5,~x.1,^1.x.5,^1.X.5-betaand^x.1.2. They run under all four option combinations and also feedtest/ranges/valid.js. I updated the fixture row counts intest/classes/range.jsto match. The full suite passes with 100% coverage, andnpm run lintpasses.