Repository navigation
fix: preserve build metadata when constructor options change - #932
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compareBuild()and the sorting helpers lose build metadata when givenSemVerobjects whose options differ from the comparison options. For example:The constructor reparses an existing object's
.versionwhen its flags differ, but.versiondeliberately omits build metadata. Reattach the existing build identifiers to that normalized string before reparsing. Keep the same-options fast path and normalization of loose input when changing to strict options.Add regressions for both flags in both directions, normalized loose input, and
compareBuild(),sort()andrsort()on version objects. Formatting and ordinary SemVer precedence retain their existing behavior:.version,format(),valid()andtoString()still omit build metadata, as discussed in #264 and #684.Validation on Windows, Node 24.11.0:
npm test --ignore-scripts: all 53 test files pass; 100% statement, branch, function and line coverage.npm run lint --ignore-scripts,npm run postlint --ignore-scripts, andgit diff --checkpass.Developed with OpenAI Codex assistance.