Repository navigation
object: Mark ECPartID.part_index field as optional - #441
Merged
Merged
Conversation
For an index, missing and explicit zero values have different semantics. At the same time, GET/HEAD already specifies the behavior for the absence. Optional notation allows to distinguish these cases in the generated code (Go in particular). Refs #427. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
ec-part-idx-optional
branch
from
October 13, 2026 09:04
bd7976c to
6b29844
Compare
cthulhu-rider
marked this pull request as ready for review
October 13, 2026 09:06
cthulhu-rider
requested review from
carpawell and
roman-khimov
as code owners
October 13, 2026 09:06
roman-khimov
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasn't been released yet, so it's not a breakage