Skip to content

ir: check signatures of container operations with session token v2 - #4251

Merged
roman-khimov merged 1 commit into
masterfrom
fix/container-sessionv2-signatures-check
Oct 28, 2026
Merged

roman-khimov merged 1 commit into
masterfrom
fix/container-sessionv2-signatures-check

Conversation

@carpawell

Copy link
Copy Markdown
Member

It feels strange, but i think that is how it should be fixed. I dont know whether we support N3 signatures for requests.

@carpawell
carpawell force-pushed the fix/container-sessionv2-signatures-check branch 3 times, most recently from fe956f6 to 8c5b899 Compare October 27, 2026 16:57
@carpawell
carpawell marked this pull request as ready for review October 27, 2026 16:57
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.24%. Comparing base (fc586ec) to head (bbab74b).

Files with missing lines Patch % Lines
pkg/innerring/processors/container/common.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4251   +/-   ##
=======================================
  Coverage   32.24%   32.24%           
=======================================
  Files         673      673           
  Lines       41624    41636   +12     
=======================================
+ Hits        13423    13427    +4     
- Misses      28201    28209    +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov
roman-khimov requested a balanced review from Copilot October 27, 2026 19:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

Comment thread pkg/innerring/processors/container/common.go Outdated
@carpawell
carpawell force-pushed the fix/container-sessionv2-signatures-check branch from 8c5b899 to f306811 Compare October 28, 2026 09:16
@roman-khimov

Copy link
Copy Markdown
Member

Conflict

Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
@carpawell
carpawell force-pushed the fix/container-sessionv2-signatures-check branch from f306811 to bbab74b Compare October 28, 2026 11:05
@roman-khimov
roman-khimov merged commit 2a9a2c3 into master Oct 28, 2026
23 of 25 checks passed
@roman-khimov
roman-khimov deleted the fix/container-sessionv2-signatures-check branch October 28, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants