Repository navigation
Conversation
Retain virtual parents and tombstones for one extra epoch, or a grace period after time-based expiration, to give nodes more time to synchronize. Closes #3621. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
October 27, 2026 17:16
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4252 +/- ##
==========================================
+ Coverage 32.24% 32.28% +0.03%
==========================================
Files 673 673
Lines 41622 41637 +15
==========================================
+ Hits 13423 13444 +21
+ Misses 28199 28193 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3621.
Grace periods reduce the race window but do not eliminate it. A late split part may still be accepted after the grace period or on a node without the parent metadata. Likewise, parts missing when a tombstone is applied are not marked by it and may be accepted later - even while the expired tombstone is retained, or after it is collected.
This is a simple mitigation that significantly reduces the risk; a more comprehensive solution may not justify its added complexity.