Skip to content

fix: pass through gpt-5.3+ and gpt-6+ model names in normalizeModel - #131

Open
AmanKRoy wants to merge 1 commit into
numman-ali:mainfrom
AmanKRoy:fix/normalize-newer-gpt-models
Open

AmanKRoy wants to merge 1 commit into
numman-ali:mainfrom
AmanKRoy:fix/normalize-newer-gpt-models

Conversation

@AmanKRoy

Copy link
Copy Markdown

Problem

normalizeModel() only knows the gpt-5.1/5.2 families. Any newer name (e.g. gpt-5.5) falls through to the pattern-based fallback and is rewritten to an older model, which the Codex backend rejects with HTTP 400.

Change

Return gpt-5.3+ and gpt-6+ names unchanged (lowercased) before the fallback. Existing mappings and the legacy fallback are untouched. AGENTS.md notes the new rule.

Tests

Added cases for gpt-5.5, GPT-5.5, gpt-5.6-luna, gpt-6-astra, gpt-10 and GPT-10-Astra (passthrough, lowercased), plus gpt-5.2, gpt-5.1-codex-max and gpt-5-codex (mapped as before).
npm run typecheck, npm test (232 passing) and npm run build pass locally.

Related

#126, #129 and #130 also add newer-model support by listing each model explicitly. This is a smaller alternative that avoids a code change per release, and it can sit alongside them.

🤖 Generated with Claude Code

Names newer than the hardcoded gpt-5.1/5.2 families fell through to the
pattern-based fallback and were rewritten to an older model, which the
Codex backend rejects with HTTP 400 (e.g. gpt-5.5).

Return gpt-5.3+ and gpt-6+ names unchanged (lowercased) before the
fallback so new models work without a code change. Existing mappings
are untouched.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Mindrocket42 added a commit to Mindrocket42/fork-opencode-codex-auth that referenced this pull request Sep 27, 2026
Adapt AmanKRoy's PR numman-ali#131 so unknown GPT-5.3+ and GPT-6+ model IDs pass through without overriding the fork's existing GPT-5.4/5.5 family normalization.

Co-authored-by: AmanKRoy <139571185+AmanKRoy@users.noreply.github.com>

Copy link
Copy Markdown

Thanks @AmanKRoy. This is the right shape. I’ve pulled the future-model passthrough into my fork’s main and adapted its placement so it preserves the existing GPT-5.4/5.5 family normalization instead of overriding it. I carried over the regression coverage and credited you in the commit: Mindrocket42/fork-opencode-codex-auth@ce8e07f. Much appreciated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants