Conversation
lforchini
requested review from
ntnx-matej-genci and
tmakatos
as code owners
September 28, 2026 16:07
Introduce register_backend and register_engine which take a name and a builder function to register it into the plugin system. Engine and Backend implementations now don't care about the exact registration mechanism. Signed-off-by: Leonardo Forchini <leonardo.forchini@nutanix.com>
lforchini
force-pushed
the
register-macros
branch
from
September 28, 2026 16:13
772eec1 to
6ec0053
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce register_backend and register_engine which take a name and a builder function to register it into the plugin system. Engine and Backend implementations now don't care about the exact registration mechanism.
I had to introduce RegisterableBackend/Engine to keep the original traits dyn-compatible.