Skip to content

test: update snapshots for upm - #1597

Merged
danielroe merged 5 commits into
nuxt:mainfrom
iiio2:feat/ump-add-feature
Oct 6, 2026
Merged

danielroe merged 5 commits into
nuxt:mainfrom
iiio2:feat/ump-add-feature

Conversation

@iiio2

@iiio2 iiio2 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

package-manager-detector new update has upm.

@iiio2
iiio2 requested a review from danielroe as a code owner October 5, 2026 16:28
@pkg-pr-new

pkg-pr-new Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
  • nuxt-cli-playground

    npm i https://pkg.pr.new/create-nuxt@1597
    
    npm i https://pkg.pr.new/nuxi@1597
    
    npm i https://pkg.pr.new/@nuxt/cli@1597
    

commit: 6c6cc42

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

CLI benchmark

@nuxt/cli v4.0.0 (baseline) vs v4.0.0 (this PR)

Metric baseline v4.0.0 head v4.0.0 Delta
nuxt --version wall time (median) 66 ms 66 ms +0.4%
nuxt --help wall time (median) 141 ms 141 ms +0.2%
nuxt dev --help wall time (median) 107 ms 104 ms -2.2%
nuxt --version modules loaded 35 35 0.0%
nuxt --version built-ins loaded 27 27 0.0%
nuxt --help modules loaded 135 135 0.0%
nuxt --help built-ins loaded 87 87 0.0%
nuxt dev --help modules loaded 64 64 0.0%
nuxt dev --help built-ins loaded 87 87 0.0%
Installed node_modules 2.46 MB 2.46 MB -0.0%
Published tarball (packed) 240.2 kB 240.2 kB 0.0%
Full report

@nuxt/cli v4.0.0 (baseline) vs v4.0.0 (head)

Setting Value
Baseline ref:eec52f07d01cb8384ffddd2e4492268ce2203b81 (v4.0.0)
Head local packages/nuxt-cli at 6d364dc (v4.0.0)
Node v24.21.0
OS Linux 6.17.0 (kernel 6.17.0-1022-azure)
CPU AMD EPYC 7763 64-Core Processor x 4
Memory 15.6 GB
Load average at start 1.90, 0.71, 0.27
Run started 2026-10-06T12:14:12.048Z

Cold CLI startup

Median of 15 interleaved runs per command, one warmup discarded.

Command baseline v4.0.0 median head v4.0.0 median Delta baseline v4.0.0 min / p95 head v4.0.0 min / p95
nuxt --version 66 ms 66 ms +0.4% 63 ms / 68 ms 64 ms / 69 ms
nuxt --version (first output byte) 61 ms 62 ms +0.9% 59 ms / 64 ms 59 ms / 65 ms
nuxt --help 141 ms 141 ms +0.2% 138 ms / 145 ms 136 ms / 146 ms
nuxt --help (first output byte) 135 ms 136 ms +0.4% 132 ms / 139 ms 131 ms / 141 ms
nuxt dev --help 107 ms 104 ms -2.2% 102 ms / 110 ms 102 ms / 108 ms
nuxt dev --help (first output byte) 102 ms 99 ms -2.2% 97 ms / 105 ms 97 ms / 103 ms
nuxt <unknown-command> (no-op) 150 ms 151 ms +0.6% 146 ms / 154 ms 148 ms / 154 ms
nuxt <unknown-command> (no-op) (first output byte) 144 ms 145 ms +0.3% 140 ms / 148 ms 142 ms / 148 ms

Module load cost

Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (native addons excluded). Built-ins loaded after bootstrap are counted separately, including the internal modules they load.

Command baseline v4.0.0 modules head v4.0.0 modules Delta baseline v4.0.0 source bytes head v4.0.0 source bytes Delta baseline v4.0.0 built-ins head v4.0.0 built-ins Delta
nuxt --version 35 35 0.0% 297.8 kB 297.8 kB 0.0% 27 27 0.0%
nuxt --help 135 135 0.0% 847.1 kB 847.1 kB 0.0% 87 87 0.0%
nuxt dev --help 64 64 0.0% 455.3 kB 455.3 kB 0.0% 87 87 0.0%

Install footprint and published tarball

Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.

Metric baseline v4.0.0 head v4.0.0 Delta
Direct dependencies of @nuxt/cli 23 23 0.0%
Packages in the installed tree (unique name@version) 39 39 0.0%
Unique package names 39 39 0.0%
Package directories on disk (cross-check) 32 32 0.0%
Installed node_modules on disk 2.46 MB 2.46 MB -0.0%
Installed files 435 435 0.0%
Install wall time (warm npm cache, median of 3) 1.31 s 1.31 s -0.1%
Published tarball (packed) 240.2 kB 240.2 kB 0.0%
Published tarball (unpacked) 780.0 kB 780.0 kB 0.0%
Files in tarball 100 100 0.0%

Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.

@codecov-commenter

codecov-commenter commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@eec52f0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1597   +/-   ##
=======================================
  Coverage        ?   83.99%           
=======================================
  Files           ?      177           
  Lines           ?    11475           
  Branches        ?     3297           
=======================================
  Hits            ?     9638           
  Misses          ?     1546           
  Partials        ?      291           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing iiio2:feat/ump-add-feature (6c6cc42) with main (eec52f0)

Open in CodSpeed

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 920324e8-b724-45e5-801f-b37538fb507a
📥 Commits

Reviewing files that changed from the base of the PR and between 955a376 and 6c6cc42.

📒 Files selected for processing (1)
  • packages/nuxt-cli/test/unit/utils/install.spec.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2e502b4c-d924-42b5-8c7e-29f16bb0e6ba
📥 Commits

Reviewing files that changed from the base of the PR and between a4b1b19 and d51be26.

⛔ Files ignored due to path filters (4)
  • capture/output/nuxt-dev-install-module.svg is excluded by !**/*.svg
  • capture/output/nuxt-dev-restart.svg is excluded by !**/*.svg
  • capture/output/nuxt-dev-static.svg is excluded by !**/*.svg
  • capture/output/nuxt-dev.svg is excluded by !**/*.svg
📒 Files selected for processing (5)
  • capture/output/nuxt-dev-install-module.txt
  • capture/output/nuxt-dev-restart.txt
  • capture/output/nuxt-dev-static.txt
  • capture/output/nuxt-dev.txt
  • packages/nuxt-cli/test/unit/utils/install.spec.ts
💤 Files with no reviewable changes (1)
  • packages/nuxt-cli/test/unit/utils/install.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The package-manager detector dependency ranges are updated to version 1.9.0. Tests cover detection of an upm.lock file and the lock-file list for upm. CLI help snapshots and documentation list upm as a supported --packageManager value.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to d51be

The upm choices match the existing detector and CLI support. The remaining changes update documentation, help, and captured output; no merge-blocking risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to dbd3c

The change affects 4 systems.

Changed systems: docs, packages/nuxt-cli, packages/create-nuxt, pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 3 changed files map to changed impact.
  • observed — packages/nuxt-cli (library) was modified; 3 changed files map to changed impact.
  • observed — packages/create-nuxt (library) was modified; 1 changed file maps to changed impact.
  • observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/add.md: The usage syntax adds upm to the accepted --packageManager values.
  • observed — Modified behavior in docs/add.md: The options table adds upm to the package managers listed for --packageManager.
  • observed — Modified behavior in docs/init.md: The command synopsis adds upm to the listed --packageManager choices.
  • observed — Modified behavior in docs/init.md: The options table adds upm to the --packageManager choices; the other displayed option entries are unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the upm snapshot updates, which are part of the changes, but it does not mention the documentation updates that also add upm as a supported package manager.
Description check ✅ Passed The description links the changes to an update in package-manager-detector that includes upm.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no need for a PR or tests 🙏

the logic here is entirely in package-manager-detector, by design, and we normally manage dependency bumps through renovate

@danielroe danielroe closed this Oct 6, 2026
@danielroe danielroe reopened this Oct 6, 2026
@danielroe danielroe changed the title feat: add upm package manager support test: update snapshots for upm Oct 6, 2026
@danielroe
danielroe enabled auto-merge October 6, 2026 11:41
@danielroe
danielroe disabled auto-merge October 6, 2026 11:57
@danielroe
danielroe force-pushed the feat/ump-add-feature branch from d51be26 to 955a376 Compare October 6, 2026 12:07
@danielroe
danielroe enabled auto-merge October 6, 2026 12:07
@danielroe
danielroe disabled auto-merge October 6, 2026 12:20
@danielroe
danielroe merged commit c3abf23 into nuxt:main Oct 6, 2026
19 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 6, 2026
@iiio2

iiio2 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks. 😊

@iiio2
iiio2 deleted the feat/ump-add-feature branch October 6, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants