Fix project sync completion lock race - #26
Merged
Merged
Conversation
Hydralerne
marked this pull request as ready for review
October 2, 2026 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The v0.1.37 release gate failed because a sync conflict became visible before its deferred project-lock release. A client could see a finished operation and still be blocked from using the project.
Publish terminal operation results and release their reservations in one SQLite transaction. Keep import reservations until the final result is published, and retain protection if a recovery journal cannot be read. Remove the separate deferred unlock paths.
Regression coverage checks status/lock agreement, rollback when either database write fails, isolation from other reservations, and restart recovery without replaying already committed files.
Component
Type of change
Checklist
go test -race ./... -skip '^TestLiveClaude$'. The excluded test would use this Mac's authenticated Claude account for a live model request; CI skips it when unauthenticated.-race.No public API or documentation changes are required.