Repository navigation
Support for new HA Database node #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giurgiur99
wants to merge
32
commits into
rc_3.0.0
Choose a base branch
from
feat/node-neutral-query
base: rc_3.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1ab87be
subsidy provider support
alexcos20 56be45c
fix comments
alexcos20 266e449
format
alexcos20 ef96af4
escrow v2
alexcos20 36406d9
use custom contracts and node
alexcos20 0d1399c
fix test
alexcos20 d45b938
fix CLAUDE.md
alexcos20 89b5ac5
fix lock
alexcos20 2df41be
bump to lib@9.3.0-next.4
alexcos20 2020fb0
Merge branch 'main' into feature/subsidy_provider
alexcos20 e02a5c8
use latest contracts in ci
alexcos20 0356539
fix ISO date guard
alexcos20 f8d7e00
updates to lib v10
alexcos20 af64001
Merge branch 'main' into feature/subsidy_provider
alexcos20 5ad4dc1
Merge branch 'main' into feature/subsidy_provider
alexcos20 daec4b9
fixes
alexcos20 2c10765
relax positional params + enforce guards
alexcos20 bc4d883
remove custom node and contracts from ci
alexcos20 51907e0
update CLAUDE.md to use node24
alexcos20 458e402
update and fix tests
alexcos20 292e80f
always show subsidy percent
alexcos20 2555ae9
fix message about subsidy support
alexcos20 692127f
Use colors for better subsidy visibility
alexcos20 6fa631c
remove duplicate token enable
alexcos20 0cda5e8
Fund only the payer's share when a prepaid subsidy covers the job
alexcos20 fb66252
Let getSubsidyStatus --subsidy query providers the node does not adve…
alexcos20 732ef2e
fix review comments
alexcos20 96040bd
use ProviderInstance for DDOs, remove Aquarius
giurgiur99 d1a0bd9
link new ocean.js
giurgiur99 48c7bdd
cleanup
giurgiur99 0a06c3b
Merge branch 'main' into feat/node-neutral-query
giurgiur99 3e07ea6
throw err
giurgiur99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test and ship the same dependency.
The linked branch provides
ProviderInstance.waitForIndexer, but the v10.1.0 library does not. A normal installation can resolve 10.1.0 under the declared^10.1.0range, so compute-input resolution fails when it calls that method. CI masks the failure by replacing the registry dependency before build and system tests. (raw.githubusercontent.com)Release a library version with the required API, require that version, and test without the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is temporary until ocean.js #2216 is released;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 6687
@giurgiur99Understood. The link is temporary until ocean.js#2216is released.The release risk remains:
package.jsonpermits@oceanprotocol/lib10.1.0, and the lockfile pins it. That version lacksProviderInstance.waitForIndexer.Before publishing the CLI, update the minimum dependency and lockfile, then run the build and system tests without the link. I’m not marking the finding as addressed yet.
You are interacting with an AI system.