Skip to content

use last ddo.js version - #216

Merged
alexcos20 merged 1 commit into
mainfrom
update-ddo-js
Nov 21, 2026
Merged

alexcos20 merged 1 commit into
mainfrom
update-ddo-js

Conversation

@dnsi0

@dnsi0 dnsi0 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Improvements

    • Improved how publishing, editing, downloading, and compute-related commands identify dataset networks and services.
    • Updated algorithm allow-list management to use the dataset’s ownership and compute-service details.
    • Improved validation of compute orders and handling of published algorithms.
  • Chores

    • Updated the underlying dataset metadata library.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CLI updates @oceanprotocol/ddo-js to ^1.1.0. Commands and helpers use its chain and service accessors. The allow and disallow commands use its ownership, compute-service, and trusted-algorithm helpers.

Changes: DDO CLI integration

Layer / File(s) Summary
Chain and service access
package.json, src/commands.ts, src/helpers.ts, test/computeChains.unit.test.ts
The dependency changes to ^1.1.0. Commands and helpers use ddo-js chain and service accessors instead of the removed local chain-ID wrapper and direct service-array lookups. The test imports getDdoChainId from ddo-js.
Trusted-algorithm access and checks
src/commands.ts
allowAlgo and disallowAlgo use ddo-js ownership and compute-service checks. They use trusted-algorithm helpers to add and remove entries. Removal now removes all matching entries; a zero removal count triggers the missing-algorithm case.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: adrigeorge

Merge Risk: Minimal · up to 049df

The change moves the CLI onto ddo-js 1.1.0 helpers. Inspection of the dependency found no concrete regression in chain routing or trusted-algorithm handling, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "use last ddo.js version" names the main change: the dependency on @oceanprotocol/ddo-js is raised from ^1.0.0 to ^1.1.0. The code changes in commands.ts, helpers.ts, and the test file move …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "use last ddo.js version" names the main change: the dependency on @oceanprotocol/ddo-js is raised from ^1.0.0 to ^1.1.0. The code changes in commands.ts, helpers.ts, and the test file move from local service-array logic to ddo-js helpers, which that upgrade enables. The title is short and specific. It has a minor typo ("last" should be "latest") but it still conveys the primary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1603c03e-0fd9-4867-b542-8191b70269c1
Commits

Reviewing files that changed from the base of the PR and between 18d24c3 and 049df45.

Files ignored due to path filters: 1

  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 4

  • package.json
  • src/commands.ts
  • src/helpers.ts
  • test/computeChains.unit.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@alexcos20 alexcos20 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20
alexcos20 merged commit c21f814 into main Nov 21, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants