You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review.
Walkthrough
The CLI updates @oceanprotocol/ddo-js to ^1.1.0. Commands and helpers use its chain and service accessors. The allow and disallow commands use its ownership, compute-service, and trusted-algorithm helpers.
Changes: DDO CLI integration
Layer / File(s)
Summary
Chain and service access package.json, src/commands.ts, src/helpers.ts, test/computeChains.unit.test.ts
The dependency changes to ^1.1.0. Commands and helpers use ddo-js chain and service accessors instead of the removed local chain-ID wrapper and direct service-array lookups. The test imports getDdoChainId from ddo-js.
Trusted-algorithm access and checks src/commands.ts
allowAlgo and disallowAlgo use ddo-js ownership and compute-service checks. They use trusted-algorithm helpers to add and remove entries. Removal now removes all matching entries; a zero removal count triggers the missing-algorithm case.
The change moves the CLI onto ddo-js 1.1.0 helpers. Inspection of the dependency found no concrete regression in chain routing or trusted-algorithm handling, so merge risk is minimal.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "use last ddo.js version" names the main change: the dependency on @oceanprotocol/ddo-js is raised from ^1.0.0 to ^1.1.0. The code changes in commands.ts, helpers.ts, and the test file move …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check
Explanation
The title "use last ddo.js version" names the main change: the dependency on @oceanprotocol/ddo-js is raised from ^1.0.0 to ^1.1.0. The code changes in commands.ts, helpers.ts, and the test file move from local service-array logic to ddo-js helpers, which that upgrade enables. The title is short and specific. It has a minor typo ("last" should be "latest") but it still conveys the primary change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Fix failing CI checks
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 1603c03e-0fd9-4867-b542-8191b70269c1
Commits
Reviewing files that changed from the base of the PR and between 18d24c3 and 049df45.
Files ignored due to path filters: 1
package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 4
package.json
src/commands.ts
src/helpers.ts
test/computeChains.unit.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Improvements
Chores