You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Aligns the CLI with the unified node status endpoint from ocean-node #1622 and ocean.js #2218.
Since the node's root GET / now returns the full status object (dropping the old nodeId/providerAddress/nodePublicKey/software keys), test/http.test.ts is rewritten to fetch node status through ocean.js getNodeStatus instead of a raw fetch — making the check transport-agnostic (HTTP and P2P) and immune to the root-endpoint field rename.
Temporarily pins @oceanprotocol/lib to the feature/unify_status_endpoints branch so all three repos stay in sync; this must be reverted to a published ^10.x release once #2218 lands.
Pack smoke tests will fail until we have a release or prerelease of ocean.js
Summary by CodeRabbit
Bug Fixes
Node status checks now recognize either supported peer identifier and validate status and version information across HTTP and P2P setups.
Chores
Updated the test environment’s Barge startup configuration.
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: de7a79f5-2d72-49b6-af2a-082253e55410
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The test now validates node status through validateNode. The dependency points to a GitHub branch, and CI updates Barge startup and P2P readiness handling.
Changes: Node status validation
Layer / File(s)
Summary
Status validation test package.json, test/http.test.ts
The test uses validateNode with NODE_URL, checks status fields and a version threshold, and removes the direct-command status test. The @oceanprotocol/lib dependency now points to the feature/unify_status_endpoints branch.
CI startup and readiness .github/workflows/ci.yml
The Barge startup step sets NODE_VERSION to pr-1622. The P2P readiness check accepts id or nodeId as the peer ID.
This PR moves the status check onto the unified node status API and pins the ocean.js dependency to a feature branch for now. The pin must be replaced with a published release before any release is cut, and package smoke tests are expected to fail until then. Merging is low risk as long as that follow-up is tracked.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "unify_status_endpoints" names the main change: the CLI moves to the unified node status endpoint, and the status test now uses ocean.js getNodeStatus. It is a branch-style identifier rather…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "unify_status_endpoints" names the main change: the CLI moves to the unified node status endpoint, and the status test now uses ocean.js getNodeStatus. It is a branch-style identifier rather than a full sentence, but it still refers to the primary change. The title is not vague or off-topic.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Fix failing CI checks
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 074e301a-1c35-41c2-93dd-5240b62c0ddf
Commits
Reviewing files that changed from the base of the PR and between 18d24c3 and 7ae55f1.
Files ignored due to path filters: 1
package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 3
.github/workflows/ci.yml
package.json
test/http.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the CLI with the unified node status endpoint from ocean-node #1622 and ocean.js #2218.
Since the node's root GET / now returns the full status object (dropping the old nodeId/providerAddress/nodePublicKey/software keys), test/http.test.ts is rewritten to fetch node status through ocean.js getNodeStatus instead of a raw fetch — making the check transport-agnostic (HTTP and P2P) and immune to the root-endpoint field rename.
Temporarily pins @oceanprotocol/lib to the feature/unify_status_endpoints branch so all three repos stay in sync; this must be reverted to a published ^10.x release once #2218 lands.
Pack smoke tests will fail until we have a release or prerelease of ocean.js
Summary by CodeRabbit