Skip to content

unify_status_endpoints - #220

Open
alexcos20 wants to merge 5 commits into
rc_3.0.0from
feature/unify_status_endpoints
Open

alexcos20 wants to merge 5 commits into
rc_3.0.0from
feature/unify_status_endpoints

Conversation

@alexcos20

@alexcos20 alexcos20 commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Aligns the CLI with the unified node status endpoint from ocean-node #1622 and ocean.js #2218.

Since the node's root GET / now returns the full status object (dropping the old nodeId/providerAddress/nodePublicKey/software keys), test/http.test.ts is rewritten to fetch node status through ocean.js getNodeStatus instead of a raw fetch — making the check transport-agnostic (HTTP and P2P) and immune to the root-endpoint field rename.

Temporarily pins @oceanprotocol/lib to the feature/unify_status_endpoints branch so all three repos stay in sync; this must be reverted to a published ^10.x release once #2218 lands.

Pack smoke tests will fail until we have a release or prerelease of ocean.js

Summary by CodeRabbit

  • Bug Fixes
    • Node status checks now recognize either supported peer identifier and validate status and version information across HTTP and P2P setups.
  • Chores
    • Updated the test environment’s Barge startup configuration.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: de7a79f5-2d72-49b6-af2a-082253e55410

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The test now validates node status through validateNode. The dependency points to a GitHub branch, and CI updates Barge startup and P2P readiness handling.

Changes: Node status validation

Layer / File(s) Summary
Status validation test
package.json, test/http.test.ts
The test uses validateNode with NODE_URL, checks status fields and a version threshold, and removes the direct-command status test. The @oceanprotocol/lib dependency now points to the feature/unify_status_endpoints branch.
CI startup and readiness
.github/workflows/ci.yml
The Barge startup step sets NODE_VERSION to pr-1622. The P2P readiness check accepts id or nodeId as the peer ID.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: jamiehewitt15

Merge Risk: Low · previous review 7ae55

This PR moves the status check onto the unified node status API and pins the ocean.js dependency to a feature branch for now. The pin must be replaced with a published release before any release is cut, and package smoke tests are expected to fail until then. Merging is low risk as long as that follow-up is tracked.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "unify_status_endpoints" names the main change: the CLI moves to the unified node status endpoint, and the status test now uses ocean.js getNodeStatus. It is a branch-style identifier rather…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "unify_status_endpoints" names the main change: the CLI moves to the unified node status endpoint, and the status test now uses ocean.js getNodeStatus. It is a branch-style identifier rather than a full sentence, but it still refers to the primary change. The title is not vague or off-topic.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 074e301a-1c35-41c2-93dd-5240b62c0ddf
Commits

Reviewing files that changed from the base of the PR and between 18d24c3 and 7ae55f1.

Files ignored due to path filters: 1

  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 3

  • .github/workflows/ci.yml
  • package.json
  • test/http.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant